Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Updates required for new psana1 release #143

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

jortiz-slac
Copy link
Contributor

Updates required for new psana1 release
-Added ":dir=" divider to commands running in drpsrcf
-Changed calibrun argument "--thr_rms" to "--thr_rms_max"

Motivation and Context

New psana1

How Has This Been Tested?

Tested by running "./makepeds -u jortiz -F -q ffbh3q -r 1" for experiment xcsx1001121.
This run includes two Epix100a and an Epix10ka2m detector

deploy_constants is currently not handling directories correctly and will be updated in the next release.

Where Has This Been Documented?

Copy link
Contributor

@mcb64 mcb64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that the parameters for the underlying calls have changed to require this, it looks reasonable to me.

I'm too lazy to check if this is, in fact, the correct syntax. :-)

@jortiz-slac jortiz-slac merged commit aa649ee into pcdshub:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants