Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: pydev_env was not showing dev typhos templates #139

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Nov 1, 2022

Description

Unset the long PYDM_DISPLAYS_PATH from pcds_conda in the pydev_env setup

Motivation and Context

The path here was masking personal dev env screens with the production screens, preventing testing of dev typhos templates when using pydev_env.

How Has This Been Tested?

Interactively only

Where Has This Been Documented?

Release notes later

@ZLLentz ZLLentz requested review from klauer and tangkong November 1, 2022 22:50
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@klauer klauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

A slight tangen and a potential topic for a typhos issue:
I ran into (I think) the same thing maybe last month - I recall seeing a confusing set of DeviceName.ui listed twice in typhos due to it finding the display once in the production installation (first) and once in the development install (second):
image
Perhaps it'd be worthwhile to list a more complete filename in that list when two have an identical name...

@ZLLentz
Copy link
Member Author

ZLLentz commented Nov 2, 2022

I saw exactly the same thing in testing but I didn't realize what it was. Good catch.

@ZLLentz ZLLentz merged commit 74584dd into pcdshub:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants