RenderAndReload() errors out if spec has negative floating point numbers for minimum or maximum

[pratik-sharma-1]

Issue details

RenderAndReload() errors out if spec has negative floating point numbers for minimum or maximum

Steps to reproduce

Spec

{
    "openapi": "3.0.0",
    "info": {
        "title": "dummy",
        "version": "1.0.0"
    },
    "paths": {
        "/dummy": {
            "post": {
                "requestBody": {
                    "content": {
                        "application/json": {
                            "schema": {
                                "type": "object",
                                "properties": {
                                    "value": {
                                        "type": "number",
                                        "format": "decimal",
                                        "multipleOf": 0.01,
                                        "minimum": -999.99
                                    }
                                }
                            }
                        }
                    }
                },
                "responses": {
                    "200": {
                        "description": "OK"
                    }
                }
            }
        }
    }
}

Sample go program

package main

import (
	"fmt"

	"github.com/pb33f/libopenapi"
)

const openAPISpec = `{"openapi":"3.0.0","info":{"title":"dummy","version":"1.0.0"},"paths":{"/dummy":{"post":{"requestBody":{"content":{"application/json":{"schema":{"type":"object","properties":{"value":{"type":"number","format":"decimal","multipleOf":0.01,"minimum":-999.99}}}}}},"responses":{"200":{"description":"OK"}}}}}}`

func main() {

	document, err := libopenapi.NewDocument([]byte(openAPISpec))
	if err != nil {
		panic(err)
	}

	_, errList := document.BuildV3Model()

	if len(errList) > 0 {
		fmt.Println(errList)
		panic("error encountered while building the model")
	}

	_, _, _, errList = document.RenderAndReload()
	if len(errList) > 0 {
		fmt.Println(errList)
		panic("error encountered while rendering the model")
	}
}

Current behaviour

RenderAndReload() errors with [yaml: cannot decode !!float -999.99 as a !!int]

Expected behaviour

Since minimum and maximum are defined as numbers , negative values should be valid

Possible cause:

1. Explicit check of value > 0 : https://github.com/pb33f/libopenapi/blob/main/datamodel/high/node_builder.go#L504-L511
2. Similar check is also present at : https://github.com/pb33f/libopenapi/blob/main/datamodel/high/node_builder.go#L495-L498

Reference

https://datatracker.ietf.org/doc/html/draft-wright-json-schema-validation-00#section-5.4
https://datatracker.ietf.org/doc/html/rfc7159#section-6

[pratik-sharma-1]

I have also tried to fix the issue PR: #377