Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): admin panel UI not rendering custom upload components #9925

Merged
merged 10 commits into from
Jan 20, 2025

Conversation

rilrom
Copy link
Contributor

@rilrom rilrom commented Dec 12, 2024

What?

Currently it is not possible to override the upload component.

Why?

The ability to override the upload component is missing from renderDocumentSlots.

How?

Adding a check to include the custom upload component if it is available.

This issue is holding me back from releasing a payload plugin.

Fixes #9591

Copy link
Contributor

@paulpopus paulpopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an e2e test checking for the text on the create URL here? Ideally checking upload > open custom drawer too but I'm ok with just checking for static text to verify that the field renders so we avoid any regressions here in the future, thank you!

@paulpopus paulpopus changed the title fix(next): missing custom upload fix(next): admin panel UI not rendering custom upload components Jan 20, 2025
@rilrom rilrom requested a review from paulpopus January 20, 2025 22:07
@paulpopus paulpopus merged commit e4fa171 into payloadcms:main Jan 20, 2025
67 checks passed
Copy link
Contributor

🚀 This is included in version v3.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a custom upload component to the edit view does not work
2 participants