Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): filters out upload specific fields for bulk editing #10726

Merged
merged 23 commits into from
Jan 22, 2025

Conversation

PatrikKozak
Copy link
Contributor

@PatrikKozak PatrikKozak commented Jan 22, 2025

What

This PR adds a filtering mechanism to exclude certain reserved fields from being displayed in the Edit Many drawer for bulk uploads. This ensures that only relevant fields are available for bulk editing.

Why

Fields like filename, mimeType, and filesize are not intended to be edited in bulk. Filtering these fields streamlines the interface and focuses on fields that are meaningful for bulk operations.

How

  • Introduced a filterOutUploadFields utility to exclude reserved fields from the field selection in bulk uploads.
  • Applied this filter to the Edit Many drawer, ensuring a more relevant and user-friendly experience.
  • Reserved fields include properties like file, mimeType, url, width, height, and others that are not applicable for bulk editing.

@PatrikKozak PatrikKozak changed the title fix: filters out upload specific fields for bulk editing fix(ui): filters out upload specific fields for bulk editing Jan 22, 2025
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, functionally this worked great.

Design wise, let's move the edit all button to the right of the next / prev doc controls.

image

@PatrikKozak PatrikKozak changed the base branch from feat/bulk-upload-edit-many to main January 22, 2025 21:04
@PatrikKozak PatrikKozak merged commit f181f97 into main Jan 22, 2025
67 checks passed
@PatrikKozak PatrikKozak deleted the fix/filter-out-upload-fields branch January 22, 2025 21:44
Copy link
Contributor

🚀 This is included in version v3.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants