fix(plugin-search): gets api route from useConfig #10632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suphon-t
changed the title
|
Seems good to me. @DanRibbens what do you think? |
jacobsfletch
approved these changes
Feb 3, 2025
jacobsfletch
changed the title
jacobsfletch
added a commit
that referenced
this pull request
Feb 3, 2025
Continuation of #10632. The `apiBasePath` property in the Search Plugin config is unnecessary. This plugin reads directly from the Payload config for this property. Exposing it to the plugin's config was likely a mistake during sanitization before passing it through to the remaining files. This property was added to resolve the types, but as result, exposed it to the config unnecessarily. This PR marks this property with the deprecated flag to prevent breaking changes.
|
🚀 This is included in version v3.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10631.
Originally the api basepath for the reindex button is resolved during plugin initialization. Looks like this happens before payload overrides the config with the
basePathfrom the next config.I've changed it so that it uses the
useConfighook, and manually tested that it works.