-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(richtext-lexical): add new paragraph button below the editor #10530
Conversation
This looks great. An edge case I can think of is whether there would be any overlap between the table add row button and this button. |
There's a tiny overlap - not sure if this edge case is worth extra complexity to fix it: CleanShot.2025-01-12.at.19.09.21.mp4We might also want to consolidate the styling of the table + button |
Looks good to me, still very much useable. Thanks for checking! |
CleanShot.2025-01-12.at.19.27.18.mp4Made the styles for table buttons & add paragraph buttons more consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should place the cursor on the new line, same as the +
button on the left margin.
🚀 This is included in version v3.17.0 |
Fixes #10448. If the last node in an editor was a block, the only way to add a paragraph below that block was to click the "+" button on the left hand-side of the editor.
This was not apparent enough for most users - thus this PR adds a more prominent, accessible "+" button that appear when hovering close to the end of the editor. This should make it easier to insert additional paragraphs, no matter what the last node is.
See it in action
CleanShot.2025-01-12.at.18.37.48.mp4