-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow running sub-tasks from tasks #10373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs docs. Also, I don't understand the use case for this at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk through change more. I'd be very interested in finding a more simple solution.
I'm wondering if workflows can have workflows instead of tasks having subtasks, or some other simplification to this in some way.
Let's hold off on adding docs until we can talk.
@@ -119,6 +119,21 @@ export const getDefaultJobsCollection: (config: Config) => CollectionConfig | nu | |||
name: 'output', | |||
type: 'json', | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a breaking change which is why I'm very cautious about getting this merged.
🚀 This is included in version v3.15.0 |
Task handlers now receive
inlineTask
as an arg, which can be used to run inline sub-tasks. In the task log, those inline tasks will have aparent
property that points to the parent task.Example:
Job log example: