Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(templates): removes all instances of React.forwardRef #10331

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

jacobsfletch
Copy link
Member

Fixes #10325. Since React 19, refs can now be passed directly through props without the need for React.forwardRef. This greatly simplifies components types and overall syntax.

@jacobsfletch jacobsfletch enabled auto-merge (squash) January 3, 2025 17:34
@jacobsfletch jacobsfletch disabled auto-merge January 3, 2025 17:36
@jacobsfletch jacobsfletch changed the title templates: removes all instances of React.forwardRef chore(templates): removes all instances of React.forwardRef Jan 3, 2025
@jacobsfletch jacobsfletch enabled auto-merge (squash) January 3, 2025 17:37
@jacobsfletch jacobsfletch merged commit 47e8158 into main Jan 3, 2025
20 checks passed
@jacobsfletch jacobsfletch deleted the fix/removes-forward-ref branch January 3, 2025 17:39
jacobsfletch added a commit that referenced this pull request Jan 3, 2025
Similar to #10331. Since React 19, refs can now be passed directly
through props without the need for `React.forwardRef`. This greatly
simplifies components types and overall syntax.
@xu4wang
Copy link

xu4wang commented Jan 5, 2025

image

Strange. it still shows the same error, I've updated all the @/components/ui/...

Copy link
Contributor

github-actions bot commented Jan 7, 2025

🚀 This is included in version v3.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Accessing element.ref was removed in React 19.
2 participants