fix: handle withoutEnlargement for undefined height or width
#10078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-enlargement-for-undefined-size
|
Hey @Zhousiru - PR looks good! I went ahead and added a test in your PR. Once the CI tests all pass, I will merge this |
|
🚀 This is included in version v3.15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This patch implements the functionality in
imageResizerto omit the generation of the image when either width or height is undefined andwithoutEnlargementis set toundefinedWhy?
#9986:
withoutEnlargementdoesn't work whenheightis undefined inupload.imageSizesHow?
This code checks if
withoutEnlargementis undefined and eithertargetWidthortargetHeightis missing. If so, it further checks whether the target dimensions (if provided) are larger than the original image dimensions. If the target would enlarge the image, it returns 'omit', skipping the resizing to prevent enlargementFixes #9986