Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new shared payjoin::directory types #418

Open
DanGould opened this issue Nov 28, 2024 · 1 comment
Open

Expose new shared payjoin::directory types #418

DanGould opened this issue Nov 28, 2024 · 1 comment
Assignees
Labels

Comments

@DanGould
Copy link
Contributor

Some types are shared between payjoin and payjoin-directory:

To re-use code and avoid

payjoin-directory crate would depend on payjoin crate with ONLY the payjoin/directory feature and no others. So it would only have access to ShortId and padding values.

That way payjoin defines all of the actual protocol bounds and payjoin-cli, payjoin-directory etc. are concrete implementations of that protocol, and we don't need to manage a separate release file

@nothingmuch
Copy link
Collaborator

After this is implemented, payjoin-directory will depend on payjoin which will depend on bitcoin, which should address this comment more meaningfully: #417 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants