Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use set_path to set subdirectory ID #416

Open
nothingmuch opened this issue Nov 28, 2024 · 0 comments
Open

Don't use set_path to set subdirectory ID #416

nothingmuch opened this issue Nov 28, 2024 · 0 comments
Assignees

Comments

@nothingmuch
Copy link
Collaborator

If the directory is deployed behind e.g. a reverse proxy and requests are rewritten exposing the public URI with a path, the current behavior of the pj_url derivation is to replace the path in its entirety.

In some places in the code .join is used, appending the subdirectory ID but the sender uses set_path as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant