Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework receive::v2 submodule into additive crate::v2 and crate::v1 submodules features #392

Open
DanGould opened this issue Nov 19, 2024 · 0 comments

Comments

@DanGould
Copy link
Contributor

DanGould commented Nov 19, 2024

I don't really love how the features are laid out inside receive especially. Send is not as big of a deal because the state machine has been flattened. If there were separate modules for separate features I think they'd be easier to reason about from docs.rs

Consider removing the not(feature = v2) feature since we want to discourage its use and one can replicate v1 soverignty by running both a directory and payjoin client on the same machine. Rust features should be additive.

@DanGould DanGould changed the title Rework receive::v2 submodule into crate::v2 and crate::v1 submodules feature gated Rework receive::v2 submodule into additive crate::v2 and crate::v1 submodules features Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants