Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-665 MP Rest Client 2.0 support #83

Merged
merged 8 commits into from
Jan 29, 2021

Conversation

jGauravGupta
Copy link

@jGauravGupta jGauravGupta commented Dec 23, 2020

@pdudits
Copy link

pdudits commented Jan 19, 2021

This implementation has huge maintenance cost. It changes internal API in many places, and breaks compatibility by renaming ComponentProvider interface.

This will be very hard to merge upstream because of that, as well as bringing upstream changes to our fork will be hard due to frequent merge conflicts -- and we are already three releases behind.

If such drastic changes are necessary, they should be done in consensus with Jersey committers -- i.e. proposing just the API changes upstream and referring to the usecases they are required for. This will be slower in short term, but much easier long-term.

Copy link

@MattGill98 MattGill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patrik's concerns seem to be being addressed in the upstream PR. For the purposes of TCK compliance, I'm merging this now. Any upstream changes can be pulled back next release cycle

@MattGill98 MattGill98 merged commit 4b9af66 into payara:jersey-2.30.payara-maintenance Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants