Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-5725: adding code to support get Claims from ID Token #137

Merged
merged 2 commits into from
Nov 9, 2021
Merged

FISH-5725: adding code to support get Claims from ID Token #137

merged 2 commits into from
Nov 9, 2021

Conversation

breakponchito
Copy link
Contributor

Adding support to get User Claims from ID Token

pdudits
pdudits approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@pdudits pdudits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the beginning I was unsure about the name "userClaimsFromIDToken" but by the end I accepted it, and we should use it all around the code

...ctors-api/src/main/java/fish/payara/security/annotations/OpenIdAuthenticationDefinition.java Outdated Show resolved Hide resolved
@breakponchito breakponchito merged commit 5a6c0dc into payara:master Nov 9, 2021
JamesHillyard pushed a commit to JamesHillyard/ecosystem-security-connectors that referenced this pull request Jan 21, 2022
@breakponchito @JamesHillyard
Merge pull request payara#137 from breakponchito/FISH-5725-add-proper…
9ae81e1 
…ty-for-microsoft-adfs-restriction

FISH-5725: adding code to support get Claims from ID Token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aubi aubi aubi left review comments

@pdudits pdudits pdudits approved these changes

@Pandrex247 Pandrex247 Awaiting requested review from Pandrex247

@jGauravGupta jGauravGupta Awaiting requested review from jGauravGupta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breakponchito @pdudits @aubi