FISH-8672 FISH-8857 Keep Semantic Versioning Happy #6777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <[email protected]>
and classes to keep semantic versioning happy Signed-off-by: Andrew Pielage <[email protected]>
Don't need to adjust private variables Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
kalinchan
approved these changes
Jun 25, 2024
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Jul 2, 2024
FISH-8672 FISH-8857 Keep Semantic Versioning Happy
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Jul 5, 2024
FISH-8672 FISH-8857 Keep Semantic Versioning Happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6677 introduced breaking changes to Core classes, which in turn broke Enterprise.
This reinstates semantic versioning and "unbreaks" the changes.
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Built this branch and started the domain - everything bon.
Built Payara Enterprise - compiles correctly.
I haven't tested for leaks (yet™), but I don't believe I've reintroduced usage of the non-WeakReference or Atomic variables anywhere.
Testing Environment
Windows 11, Zulu 11.0.23
Documentation
N/A
Notes for Reviewers
I am aware these changes are ugly and fragile. It is however the state we end up in when we have a split codebase and enforce semantic versioning. We're in a bit of a pickle because the Core major versions are somewhat tied to Jakarta APIs - 7.0.0.Alpha1 has already been released for usage with Payara 7.
Naming is also hard - if you can think of better names for the "new" variables & classes please suggest them!