FISH-8317 - Microprofile Config NPE for profiled setting #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplifies the check in case of a same ordinal value source is around. Left comments and extended unit test to make sure the desired behaviour is tested.
Elifzeynepedman
changed the title
|
Hi @Elifzeynepedman this has been sitting for a while. I would appreciate if this would find it's way into the next release 6.2024.3. Thanks! |
Pandrex247
approved these changes
Mar 22, 2024
|
LGTM, thanks! |
|
Thanks for merging @Pandrex247 |
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Apr 4, 2024
FISH-8317 - Microprofile Config NPE for profiled setting
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
May 2, 2024
FISH-8317 - Microprofile Config NPE for profiled setting
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
May 8, 2024
FISH-8317 - Microprofile Config NPE for profiled setting
pdurbin
added a commit
to IQSS/dataverse
that referenced
this pull request
Aug 22, 2024
The _CT_ version is not needed now that we have upgraded to Payara 6.2024.6 in #10495 which included this fix: payara/Payara#6550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important Info
Blockers
None
Testing
New tests
Included in PR
Testing Performed
I ran
ConfigExpressionResolverTest, which has been extended in this PR, too.Testing Environment
Fedora 39 with Maven 3.9.6 and Java 17.0.9
Documentation
Notes for Reviewers
If you want to see the failing test, simply checkout the PR branch and reset HEAD to one commit before. I compiled Payara using
mvn package -Dmaven.javadoc.skip -DskipTests -pl nucleus/payara-modules/nucleus-microprofile/config-service -amand ran the tests from my IDE.