FISH-8129 Add JDK 21 Docker Images #6505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds builds of our Docker images based on JDK 21.
Also updates various test and build plugin dependencies since otherwise it doesn't seem to like the latest Windows and Docker Desktop versions - testcontainers was complaining about being unauthorised to create containers.
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
mvn clean install -DskipTests -T 1Cmvn clean install -PBuildDockerImages -pl .\appserver\extras\docker-images\ -amd- passed.mvn clean install -PBuildDockerImages -pl .\appserver\extras\docker-images\tests\ "-Ddocker.payara.tag=6.2023.12-SNAPSHOT-jdk21"- passed.mvn clean install -PBuildDockerImages,!generate-jdk21-docker-image -pl .\appserver\extras\docker-images\ -amd -DskipTests- checked maven build output and it didn't generate a JDK 21 image.Testing Environment
Windows 11
Documentation
payara/Payara-Documentation#347
Notes for Reviewers
None