Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-7262 : monitoring console using jQuery 3.6.1 #6483

Merged
merged 2 commits into from
Dec 4, 2023
Merged

FISH-7262 : monitoring console using jQuery 3.6.1 #6483

merged 2 commits into from
Dec 4, 2023

Conversation

luiseufrasio
Copy link
Contributor

Description

Vulnerability on JQuery 1.2 < 3.5.0

Important Info

Blockers

Depends On:

Testing

New tests

None

Testing Performed

Testing Environment

Zulu JDK 11.0.11 on Windows 11 with Maven 3.8.4

@luiseufrasio
Copy link
Contributor Author

jenkins test please

1 similar comment
@luiseufrasio
Copy link
Contributor Author

jenkins test please

Pandrex247
Pandrex247 requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See payara/monitoring-console#39 (review)

@luiseufrasio
Copy link
Contributor Author

jenkins test please

aubi
aubi approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@aubi aubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it locally, so after solving the infrastructure stuff (where to publish the artifact + build), the PR is fine.

@luiseufrasio
Copy link
Contributor Author

jenkins test please

@luiseufrasio luiseufrasio requested review from Pandrex247 and removed request for Pandrex247 November 20, 2023 22:41
@luiseufrasio
Copy link
Contributor Author

jenkins test please

1 similar comment
@luiseufrasio
Copy link
Contributor Author

jenkins test please

breakponchito
breakponchito approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breakponchito
Copy link
Contributor

Jenkins test please

@eliotmartin eliotmartin merged commit 6f78607 into payara:master Dec 4, 2023
1 check passed
@aubi
Copy link
Contributor

aubi commented Dec 4, 2023

Thank you, @eliotmartin

@dependabot dependabot bot mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aubi aubi aubi approved these changes

@breakponchito breakponchito breakponchito approved these changes

@Pandrex247 Pandrex247 Awaiting requested review from Pandrex247

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luiseufrasio @breakponchito @aubi @Pandrex247 @eliotmartin