FISH-7841: fixing path to localize hazelcast configuration file #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
|
Still testing |
|
already tested |
Pandrex247
changed the title
Pandrex247
reviewed
Nov 13, 2023
Pandrex247
reviewed
Nov 13, 2023
|
Otherwise eyeballing it LGTM |
…ast-config-file' into FISH-7841-fixing-path-for-hazelcast-config-file
|
Jenkins test please |
Pandrex247
approved these changes
Nov 13, 2023
|
@Pandrex247 I think there has been a regression of this fix. It was originally fixed in 6.2023.12 and has been working for me since then. But I just tried upgrading to 6.2024.4 and it is no longer working, the config is not loaded again. |
|
Interesting, that class hasn't been changed since this fix. Please feel free to raise an issue with a reproducer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to locate the hazelcast config file on another folder
Description
This is a fix for a reported bug regarding file config location for hazelcast
Important Info
Blockers
Testing
New tests
Testing Performed
Manual testing with hazelcast configuration file:
testing hazel cast file on the current directory:test.xml
command: java -jar payara-micro.jar --hzconfigfile test.xml
`
[2023-11-10T12:11:29.633-0600] [] [INFO] [] [fish.payara.boot.runtime.BootCommand] [tid: _ThreadID=1 _ThreadName=main] [timeMillis: 1699639889633] [levelValue: 800] [[
Boot Command set returned with result SUCCESS : PlainTextActionReporterSUCCESSDescription: set AdminCommandnull
hazelcast-runtime-configuration.hazelcast-configuration-file=test.xml
]]
[2023-11-10T12:11:30.289-0600] [] [INFO] [] [fish.payara.nucleus.hazelcast.HazelcastCore] [tid: _ThreadID=31 _ThreadName=RunLevelControllerThread-1699639889692] [timeMillis: 1699639890289] [levelValue: 800] Loading Hazelcast configuration from file: test.xml
[2023-11-10T12:11:33.731-0600] [] [INFO] [] [fish.payara.nucleus.cluster.PayaraCluster] [tid: _ThreadID=97 _ThreadName=Executor-Service-1] [timeMillis: 1699639893731] [levelValue: 800] [[
Data Grid Status
Payara Data Grid State: DG Version: 5 DG Name: mycluster DG Size: 1
Instances: {
DataGrid: mycluster Name: Happy-Cavefish Lite: false This: true UUID: be43eb84-7ef7-4fb5-bf07-e2159f842cbe Address: /172.28.253.32:5701
}]]
`
and the fix for custom folder for the hazelcast file: hazel/hazelcast-config.xml
command: java -jar payara-micro.jar --hzconfigfile hazel/hazelcast-config.xml
`
[2023-11-10T12:42:36.842-0600] [] [INFO] [] [fish.payara.boot.runtime.BootCommand] [tid: _ThreadID=1 _ThreadName=main] [timeMillis: 1699641756842] [levelValue: 800] [[
Boot Command set returned with result SUCCESS : PlainTextActionReporterSUCCESSDescription: set AdminCommandnull
hazelcast-runtime-configuration.hazelcast-configuration-file=hazel/hazelcast-config.xml
]]
[2023-11-10T12:42:37.466-0600] [] [INFO] [] [fish.payara.nucleus.hazelcast.HazelcastCore] [tid: _ThreadID=32 _ThreadName=RunLevelControllerThread-1699641756902] [timeMillis: 1699641757466] [levelValue: 800] Loading Hazelcast configuration from file: hazel/hazelcast-config.xml
[2023-11-10T12:42:41.049-0600] [] [INFO] [] [fish.payara.nucleus.cluster.PayaraCluster] [tid: _ThreadID=99 _ThreadName=Executor-Service-1] [timeMillis: 1699641761049] [levelValue: 800] [[
Data Grid Status
Payara Data Grid State: DG Version: 5 DG Name: customName DG Size: 1
Instances: {
DataGrid: customName Name: Excited-Anglerfish Lite: false This: true UUID: 97929393-4e55-4e6f-b54c-95fd5e4e60e3 Address: /172.28.253.32:5701
}]]
`
with more than one folder: java -jar payara-micro.jar --hzconfigfile hazel/temp/hazelcast-config.xml
`
[2023-11-10T13:25:09.268-0600] [] [INFO] [] [fish.payara.boot.runtime.BootCommand] [tid: _ThreadID=1 _ThreadName=main] [timeMillis: 1699644309268] [levelValue: 800] [[
Boot Command set returned with result SUCCESS : PlainTextActionReporterSUCCESSDescription: set AdminCommandnull
hazelcast-runtime-configuration.hazelcast-configuration-file=hazel/temp/hazelcast-config.xml
]]
[2023-11-10T13:25:09.954-0600] [] [INFO] [] [fish.payara.nucleus.hazelcast.HazelcastCore] [tid: _ThreadID=31 _ThreadName=RunLevelControllerThread-1699644309320] [timeMillis: 1699644309954] [levelValue: 800] Loading Hazelcast configuration from file: hazel/temp/hazelcast-config.xml
[2023-11-10T13:25:13.869-0600] [] [INFO] [] [fish.payara.nucleus.cluster.PayaraCluster] [tid: _ThreadID=98 _ThreadName=Executor-Service-1] [timeMillis: 1699644313869] [levelValue: 800] [[
Data Grid Status
Payara Data Grid State: DG Version: 5 DG Name: customName DG Size: 1
Instances: {
DataGrid: customName Name: Strange-Medusafish Lite: false This: true UUID: cdcf8a5a-82fa-4f39-ab0d-5b784689aac0 Address: /172.28.253.32:5701
}]]
`
The name of the cluster was provided from the hazelcast file config
Testing Environment
Ubuntu 20.04, JDK 11, maven 3.8.6
Documentation
Notes for Reviewers