FISH-7964 FISH-7239 FISH-7222 Upgrade Metro, Santuario and Woodstox #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
changed the title
Pandrex247
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Built and ran through EE7 samples locally with payara/patched-src-metro-wsit#23
LGTM
Pandrex247
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Typical, moment I pressed approve my brain went "gotcha" - you need to update the third party license file for WoodStox and Santuario
https://github.com/payara/Payara/blob/master/appserver/packager/legal/src/main/resources/glassfish/legal/3RD-PARTY-LICENSE.txt
Pandrex247
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important Info
Blockers
Patched Metro release payara/patched-src-metro-wsit#23
Testing
New tests
Testing Performed
Testing Environment
Documentation
Notes for Reviewers
Had to upgrade woodstox due to osgi issues