FISH-7044: preventing the addition of multiple HSTS header for response #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
2 similar comments
|
Jenkins test please |
|
Jenkins test please |
Pandrex247
approved these changes
Aug 18, 2023
Pandrex247
requested changes
Aug 18, 2023
nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/HSTSFilter.java
Show resolved
Hide resolved
|
Jenkins test please |
Pandrex247
approved these changes
Aug 18, 2023
This was referenced Sep 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fix to prevent multiple security headers of Strict-Transport-Security on the response
Description
This is a fix for the following reported bug: #6178
Important Info
Blockers
Testing
New tests
Testing Performed
Manual testing with the reproducer included on the ticket: https://payara.atlassian.net/browse/FISH-7044
Now the request is working fine adding just one occurrence of the security header on the response:
`
8m2pcqb77qu6lh5pl7v35pgyhauot2ntazall9f4idjs5lypnu5u83k6tf165ijyl64r0nf8mm1kexkclstpr13xgtmidw25pjv6yx6w2qyvm6jxu2vduxtj1mxsfralqbs4hss1ka6cpxdejq1nxly97p81zcqhpg22952l4rt6pk30qkm6f96ob7h33iines80f2bj6ziwwlimewj2az7rsoiae1nwskyyde4uh9l1xebng8e0vyr68pg3kc8l8067cjqy6lblvuk2xc5oiw01lasqnzi9vmrokal7scnik13x8xyuv1r54btm7mdxt97pu0xydhj2ahrrsnqgqx1ydsm41wyyh7de01zy0ktufu6okdouzkk2hnz94ywbjywsb7smwz2dffirm4nn36ah3nggvftwt8is6xl7xk8mj2phe0gl8gro4zz0xlrafub3aqom7xoen29rkevcsdgtm6cyegityc6qnoxqowoum69bnhwi1d9xjn5p9l6ax683kjah7988nlr4t1mhrw9sgce3vbn571xry92w1hfdlqct5atwfmyplkxvnx5s4lv5mww910mkj8ojykm634wm2jnfqrfvku6vpuky0oxchxpjl3napjy40hdkfk24nz52dr6vumh4ys7eu05ozbd3rv15dvld3glmkox0w8< HTTP/2 200
< strict-transport-security: max-age=31536000
< content-type: text/plain
`
Testing Environment
Windows 11, Azul jdk 11, maven 3.8.3
Documentation
Notes for Reviewers