Fish 7426 fix payara config cache timing comm #6291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do synchronization only when setting data, otherwise use the fast path.
|
Jenkins test please |
|
Do not merge until the same change in Enterprise is finished completely. |
FISH-7426 improve logger speed - field initialization, use supplier
FISH-7426 another variable naming clarification -- milliseconds FISH-7426 fixing config provider resolver to return seconds from config cache The value cacheDurationSeconds returned milliseconds by mistake (misleading method name). FISH-7426 update copyright years
aubi
force-pushed
the
FISH-7426-fix-payara-config-cache-timing-comm
branch
from
476c8b5 to
5518045
Compare
|
Jenkins test please |
Pandrex247
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renaming variables according to their content and fix code accordingly. Also do synchronization only when setting data, otherwise use the fast path.
The problem was, that the config didn't cache at all and always did search for the DurationSeconds.
Testing
Testing Performed
I use the reproducer from Jira ticket, using only the simple request (basically simple REST):
Comparison:
Requests/sec: 3543.07Requests/sec: 1400.88Requests/sec: 35984.01Feel free to correct this result as it seems really to fast.
Testing Environment
Linux, OpenJDK 11 (compile) 17 (run)