FISH-5974 Specify system-property with Double Quotes in preboot-command File #5599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FISH-5974 Specify system-property with Double Quotes in preboot-command File
Pandrex247
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug fix where putting double quotes in a command stored in a preboot-command file would result in
UnacceptableValueException: Invalid parameter: name_value. This parameter may not have more than one value.Important Info
Blockers
None
Testing
New tests
No new tests. Added this scenario to existing tests
Testing Performed
Manually tested against the reproducer and values from unit test in regex101.
Testing Environment
Windows 10, JDK 11, Maven 3.6.3
Documentation
N/A
Notes for Reviewers
The new regex works by using a positive lookahead to check the current character is not a double or single quote preceded by a backslash, which checked by using a nested negative lookbehind.
This regex can be seen and tested in regex101 here: https://regex101.com/r/2aVRtd/1