FISH-5937 Crashes during deploy of app with HealthCheck #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every webapp with healthcheck is periodically called every 12 seconds. This call may come when the application is not ready such as mid-deployment. This stops HealthCheck calls on apps which aren't ready.
Important Info
Blockers
None.
Testing
New tests
None
Testing Performed
Manually tested the warnings outputted to the server logs no longer appear with the reproducer attached.
Testing Environment
Windows 10, JDK 11, Maven 3.6.3
Documentation
None
Notes for Reviewers
FISH-5937 ticket mentions other errors, these are caused by stopping and starting the server as the reproducer says. These are not HealthCheck related and are not related to this ticket and fix.