-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FISH-5892: recreating truststore file when corrupted #5569
Merged
breakponchito
merged 4 commits into
payara:master
from
breakponchito:FISH-5892-autocorrect-corrupted-trutstore
Jan 20, 2022
Merged
FISH-5892: recreating truststore file when corrupted #5569
breakponchito
merged 4 commits into
payara:master
from
breakponchito:FISH-5892-autocorrect-corrupted-trutstore
Jan 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins test |
rdebusscher
reviewed
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Jenkins test |
1 similar comment
Jenkins test |
Pandrex247
requested changes
Jan 19, 2022
.../common/common-util/src/main/java/com/sun/enterprise/security/store/AsadminSecurityUtil.java
Outdated
Show resolved
Hide resolved
Jenkins test |
Jenkins test |
Pandrex247
requested changes
Jan 20, 2022
.../common/common-util/src/main/java/com/sun/enterprise/security/store/AsadminSecurityUtil.java
Outdated
Show resolved
Hide resolved
… .gfclient folder
Jenkins test |
Pandrex247
requested changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestion
.../common/common-util/src/main/java/com/sun/enterprise/security/store/AsadminSecurityUtil.java
Outdated
Show resolved
Hide resolved
Jenkins test |
Pandrex247
approved these changes
Jan 20, 2022
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Jan 24, 2022
…ct-corrupted-trutstore FISH-5892: recreating truststore file when corrupted
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jan 28, 2022
…ct-corrupted-trutstore FISH-5892: recreating truststore file when corrupted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating truststore file when corrupted
Description
this is a fix of a reported issue when reading a corrupted truststore for secure administration
Important Info
Blockers
Testing
New tests
Testing Performed
Local testing by using a blank truststore file to simulate corrupted file
Testing Environment
Windows 11, zulu JDK 8U312
Documentation
Notes for Reviewers