Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5780 FISH-5779 create web component invocation around mp health check call #5540

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

aubi
Copy link
Contributor

@aubi aubi commented Dec 17, 2021

Description

Web application with a class annotated by combination of MP Health and EJB:

@Readiness
@ApplicationScoped

Such application reports "No valid EE environment for injection of JdbcHealthCheck".

This PR adds WebComponentInvocation around the HealthCheck, so the EE environment is working. Annotation like Inject and EJB work reliably.

Testing

Testing Performed

Periodically deploy testing app and try localhost:8080/health.

Testing Environment

Tried on Linux, OpenJDK 8 and 11

Notes for Reviewers

Reproducer app attached to the JIRA ticket, including testing scripts.

@aubi aubi requested review from AlanRoth and pdudits December 17, 2021 18:29
@aubi
Copy link
Contributor Author

aubi commented Dec 17, 2021

Jenkins test please

Copy link

@AlanRoth AlanRoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with reproducer, works as expected.

@aubi aubi merged commit 8ce5c38 into payara:master Dec 20, 2021
@aubi aubi deleted the FISH-5780-no-valid-ee-in-mp-health branch December 21, 2021 13:12
JamesHillyard pushed a commit to JamesHillyard/Payara that referenced this pull request Jan 24, 2022
…health

FISH-5780 FISH-5779 create web component invocation around mp health check call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants