Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5878 Add Certificate Alias Property Names Into Payara API as Constants #5527

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

kalinchan
Copy link
Member

Description

Added certificate alias properties as constants to Payara API

Important Info

Blockers

N/A

Testing

New tests

N/A

Testing Performed

Build Payara and checked to see if CertificateAlias.JAX_RS_CLIENT and CertificateAlias.REST_CLIENT were available from API Dependency

Testing Environment

maven 3.6.3 openjdk version "1.8.0_302" ubuntu 20.04

Documentation

n/a

Notes for Reviewers

n/a

@kalinchan
Copy link
Member Author

jenkins test please

@breakponchito breakponchito self-requested a review December 7, 2021 15:53
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalinchan
Copy link
Member Author

jenkins test please

Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalinchan
Copy link
Member Author

kalinchan commented Dec 8, 2021

@Pandrex247 The properties are correct, they are the same as in the documentation. I believe the one mentioned in https://github.com/payara/Payara/blob/payara-server-5.2021.9/appserver/payara-appserver-modules/microprofile/rest-client-ssl/src/main/java/fish/payara/microprofile/jaxrs/client/ssl/PayaraConstants.java are for adding it to the Microprofile Config? And I also don't believe this file is included in the Payara API so it is not accessible when the API is added as a dependency.

However, https://github.com/payara/ecosystem-rest-ssl-configuration/blob/master/src/main/java/fish/payara/ecosystem/jaxrs/client/ssl/PayaraConstantsExtension.java is included when the user adds the rest-ssl dependency, but this only includes the JAX-RS Client Certificate Alias

@Pandrex247
Copy link
Member

I'm not suggesting including the PayaraConstants file in the API, I'm suggesting that you drop the duplicate property from the PayaraConstants file and have rest-client-ssl use the property from the API, rather than relying on us to keep the two in sync.

@kalinchan
Copy link
Member Author

I have made the requested changes. I will release a new version of ecosystem-rest-client-ssl once Payara 5.2022.1 is released. payara/ecosystem-rest-ssl-configuration#1

@kalinchan kalinchan requested a review from Pandrex247 December 9, 2021 10:08
@kalinchan
Copy link
Member Author

jenkins test please

@kalinchan kalinchan merged commit 41bc02b into payara:master Dec 10, 2021
JamesHillyard pushed a commit to JamesHillyard/Payara that referenced this pull request Jan 24, 2022
FISH-5878 Add Certificate Alias Property Names Into Payara API as Constants
@kalinchan kalinchan deleted the FISH-5878 branch April 4, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants