FISH-5835 ClassFileWriter 1.2.5 #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <[email protected]>
|
jenkins test please |
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Jan 24, 2022
FISH-5835 ClassFileWriter 1.2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue with Weld creating proxies with Java 5 style signatures, which lead to
Signature Parse error: Expected Field Type Signaturewhen parsing annotations with enum parameters with non-default values.Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Ran Payara Samples on JDK 8, 11, and 17 - no issues.
Ran Java EE 7 Samples on JDK 8, 11, and 17 - no issues.
Testing Environment
WSL OpenSUSE 15.3, Zulu JDK 8u312, 11.0.13, 17.0.1
Documentation
N/A
Notes for Reviewers
None.