FISH-5832 FISH-5833 Weld 3.1.8 and Weld SPI 3.1.SP4 #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <[email protected]>
- reimplemented ProxyServicesImpl, because Weld changed behavior and added methods to the interface and previous implementation caused failure of cdi_all tests Signed-off-by: Andrew Pielage <[email protected]>
|
Jenkins test please |
aubi
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title.
Updates Weld to a version that works with JDK 17.
PR does not constitute support for CDI under JDK 17 - there are failures in Payara Samples that indicate an issue in Weld with the resolution of the
RolesPermittedannotation. Java reflect can't parse the signature of thesemanticsenum, specifically when it's the Weld Proxy being parsed (it's using JDK 1.5 type signatures which support for was removed in JDK 17):fish.payara.cdi.auth.roles.LogicalOperator -- Signature Parse error: Expected Field Type SignatureThis does however only occur when the server is running under JDK 17 since it's a change in the JDK itself that breaks things.
Important Info
Blockers
None.
Testing
New tests
None
Testing Performed
Started the server and ran Payara Samples without issue - JDK 8
Started the server and ran Payara Samples without issue - JDK 11
Testing Environment
WSL OpenSUSE 15.3, Zulu JDK 8u312 and 11.0.13
Documentation
N/A
Notes for Reviewers
None