FISH-5812 HK2 Cannot Resolve OSGi on JDK 17 #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
|
Copyright needs updating in most files |
Signed-off-by: Andrew Pielage <[email protected]>
|
Jenkins test please |
JamesHillyard
approved these changes
Nov 2, 2021
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Nov 18, 2021
FISH-5812 HK2 Cannot Resolve OSGi on JDK 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OSGi changes to allow HK2 to resolve OSGi and for the server to boot.
Note that this does not constitute Payara supporting JDK 17 - it simply fixes this particular issue of the Felix and HK2 not even able to boot.
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Started the domain and loaded admin console successfully on JDK 8 and 11 without error
Started the domain successfully in JDK 17 without error (loading the admin console is a separate can of worms)
Testing Environment
Windows 10.
Zulu JDK 8u312, 11.0.13, and 17.0.1
Documentation
N/A
Notes for Reviewers
If you've started the admin console on JDK 8 and/or 11, you may need to clean the domain before attempting to start on JDK 17 since it may try to load the admin console automatically.