Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-773 Fix EJB Scheduler / ApplicationID in TIMER_TBL #5406

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

alexk201
Copy link
Contributor

@alexk201 alexk201 commented Sep 10, 2021

Description

Fixed the EJB timer bug introduced in #3b2dd29 / reported in #4650. We've manually patched the 'ejb-container' and 'payara-micro-service' module since Payara version 5.201 and it seems to be working very well.

Testing

Testing Performed

Manually deployed a sample application using persistent EJB timers. Performed multiple redeployments to see if the application id is preserved and the timers get removed:

1st redeploy

[2021-09-10T14:47:38.596+0200] [Payara 5.2021.8-SNAPSHOT] [INFORMATION] [] [javax.enterprise.system.container.ejb.com.sun.ejb.containers] [tid: _ThreadID=122 _ThreadName=admin-thread-pool::admin-listener(1)] [timeMillis: 1631278058596] [levelValue: 800] [[
  [1] timers deleted for id: 106907436383141888]]

2nd redeploy

[2021-09-10T14:47:49.658+0200] [Payara 5.2021.8-SNAPSHOT] [INFORMATION] [] [javax.enterprise.system.container.ejb.com.sun.ejb.containers] [tid: _ThreadID=133 _ThreadName=admin-thread-pool::admin-listener(2)] [timeMillis: 1631278069658] [levelValue: 800] [[
  [1] timers deleted for id: 106907436383141888]]

Testing Environment

Zulu JDK 1.8.0_302 on Windows 10 with Maven 3.8.1

@alexk201 alexk201 changed the title Fixes EJB scheduler bug described in #4650 FISH-773 Fix EJB Scheduler / ApplicationID in TIMER_TBL Sep 17, 2021
@rdebusscher rdebusscher added the PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. label Sep 23, 2021
@rdebusscher
Copy link

Hi @alexk201

Thank you for the PR! We're happy to receive your contribution, however, before we can proceed you will need to sign the CLA and send it to us.

Payara CLA Form

Regards
Rudy

@alexk201
Copy link
Contributor Author

Oh yeah sorry, just sent it over...

@smillidge smillidge added PR: CLA CLA submitted on PR by the contributor and removed PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. labels Sep 29, 2021
@smillidge
Copy link
Contributor

Thanks CLA has been received

@Pandrex247
Copy link
Member

Jenkins test please

Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breakponchito breakponchito merged commit e78bd63 into payara:master Nov 3, 2021
JamesHillyard pushed a commit to JamesHillyard/Payara that referenced this pull request Nov 18, 2021
FISH-773 Fix EJB Scheduler / ApplicationID in TIMER_TBL
aubi pushed a commit to aubi/Payara that referenced this pull request Jan 3, 2022
FISH-773 Fix EJB Scheduler / ApplicationID in TIMER_TBL
@alexk201 alexk201 deleted the fix/issue-4650 branch January 4, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants