FISH-5693 Updated multiple keystore delimiter to be OS dependent #5395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesHillyard <[email protected]>
JamesHillyard
requested review from
rdebusscher,
aubi,
Pandrex247 and
kalinchan
|
Jenkins test please |
aubi
approved these changes
Sep 1, 2021
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
FISH-5693 Updated multiple keystore delimiter to be OS dependent
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-5693 Updated multiple keystore delimiter to be OS dependent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bugfix for FISH-1342 which introduced the ability to specify multiple keystores, however this didn't work on Windows due to the delimiter being ':'.
This has been changed to use File.pathSeparator which is OS dependent meaning the delimiter is still ':' for Linux but ';' for Windows, allowing this feature to work. Changes have also been made to the keystore path for MultipleKeystoresConfigurationTest meaning SecureCustomHttpListenerTest now passes on Windows.
The same delimiter changes have been made to FISH-5639 so this displays the keystores correctly on Windows.
Important Info
Testing
Testing Performed
Manually tested the feature works on windows. Tested the Multiple Keystores test in Payara Samples ensuring it passes and works correctly on windows. Manually tested FISH-5639 produces the expected behaviour with these changes.
Ensured multiple keystores still works on Linux.
Testing Environment
Windows 10 Pro, Maven 3.6.3, JDK8
Documentation
Documentation PR: payara/Payara-Community-Documentation#241