FISH-1530 allow multiple servers and tags with empty url and name #5343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is required by TCK, discussion is here: eclipse/microprofile-open-api#453
|
Jenkins test please |
Pandrex247
approved these changes
Jul 14, 2021
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-1530 allow multiple servers and tags with empty url and name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify comparison of servers and tags in OpenApi to allow multiple entities without data (url or name). Without it, TCK fails.
GH issue: eclipse/microprofile-open-api#453
This change is required by TCK, discussion is here:
eclipse/microprofile-open-api#453
I added also a note how to improve the TCK.
Testing
Testing Performed
Tested manually, unit tests, TCK without modification
Checkout TCK runner from a branch: https://github.com/payara/MicroProfile-TCK-Runners/tree/FISH-1530