FISH-1068 in generated openapi omit default style for parameter #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test |
1 similar comment
|
Jenkins test |
kalinchan
approved these changes
Jul 9, 2021
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-1068 in generated openapi omit default style for parameter
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit d83e568.
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 23, 2021
FISH-1068 in generated openapi omit default style for parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #5111
The solution is simple -- don't fill style parameter as the value "simple" is incorrect for some usages (e.g. query of header parameters). The standard has meaningful defaults, so it is not necessary to calculate the value based on usage.
Testing
Testing Performed
manually - in the generated openapi is missing "style: simple" in the parameter
I also tried openapi-generator-cli and there is no problem without style.