[FISH-5488] set fish.payara.tenantcontrol.blocking.disable system pro… #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty default to true
rdebusscher
reviewed
Jul 2, 2021
| @@ -66,7 +69,7 @@ public TenantControl saveCurrentTenant() { | |||
| if (invocation != null) { | |||
| tenantControl = invocation.getRegistryFor(TenantControl.class); | |||
| if (tenantControl == null && ctxUtil.isInvocationLoaded()) { | |||
| blockingDisabled = Boolean.getBoolean(DISABLE_BLOCKING_PROPERTY); | |||
| blockingDisabled = getDisableBlockingProperty.get(); | |||
There was a problem hiding this comment.
Why is the static variable overwritten here?
There was a problem hiding this comment.
So it's possible to change the system property without restarting the instance and having it take effect
|
jenkins test |
Pandrex247
approved these changes
Jul 2, 2021
yea probably :) Not worth changing at this point though |
rdebusscher
approved these changes
Jul 5, 2021
aubi
pushed a commit
to aubi/Payara
that referenced
this pull request
Jan 3, 2022
…perty default to true (payara#5325)
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Apr 26, 2023
…perty default to true (payara#5325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…perty default to true
Description
Improvement. Eliminates regressions due to blocking of nodes with non-existent apps
while trying to retrieve Hazelcast objects