FISH-666 FISH-1372 MicroProfile 4.1 #5303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
commented
Jun 10, 2021
| BiConsumer<? super String, ? super Set<HealthCheck>> mergeHealthCheckMap | ||
| = (key, value) -> healthChecks.merge(key, value, (oldValue, newValue) -> { | ||
| oldValue.addAll(newValue); | ||
| return oldValue; | ||
| }); | ||
| //FIXME most likely this unintentionally changes the fields |
There was a problem hiding this comment.
Presumably this is referring to the deep vs. shallow copy problem
|
Is using the newly decided /health/started of RC3! 👍 |
lprimak
approved these changes
Jun 12, 2021
|
jenkins test |
|
build fails... MP Health? 3.1 is not out yet I guess :) |
|
Correct. |
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Pandrex247
force-pushed
the
FISH-1372-Community
branch
from
a4c7483 to
ad6b6e3
Compare
|
Rebased ontop of #5318 |
Pandrex247
changed the title
|
Jenkins test please |
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-666 FISH-1372 MicroProfile 4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Feature/Improvement.
Implements MicroProfile 4.1, which consists of just MicroProfile Health 3.1.
MicroProfile Health 3.1 introduces a
@Startupannotation.Also increments JWT-Auth for 1.2.1, which appears to just be a patch update with no changes - something presumably wrong with the release of 1.2.
Important Info
Blockers
payara/MicroProfile-TCK-Runners#147
Related
payara/MicroProfile-TCK-Runners#152
#5372
Testing
New tests
None.
Testing Performed
Ran all of the MicroProfile TCKs locally.
Testing Environment
Windows 10, JDK 8.
WSL OpenSUSE Leap 15.2, JDK 8.
Documentation
payara/Payara-Community-Documentation#170
Notes for Reviewers
None.