FISH-1167 - Fix Inconsistent Synchronization in Password Alias Alterations for Remote Instances #5284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ord alias input identifier. Signed-off-by: James Hillyard <[email protected]>
|
jenkins test please |
lprimak
approved these changes
Jun 3, 2021
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 9, 2021
FISH-1167 - Fix Inconsistent Synchronization in Password Alias Alterations for Remote Instances
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-1167 - Fix Inconsistent Synchronization in Password Alias Alterations for Remote Instances
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit 311d088.
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit 311d088.
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit 311d088.
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
FISH-1167 - Fix Inconsistent Synchronization in Password Alias Alterations for Remote Instances
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 23, 2021
FISH-1167 - Fix Inconsistent Synchronization in Password Alias Alterations for Remote Instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverted the changed made in ZDEP-1987, fixing the inconsistent behaviour described in FISH-1167 as the alias is now made everywhere. The bug which ZDEP-1987 fixed has been replaced by changing the aliasNameNew text property from the Admin Console UI to 'id'. This means the aliasname isn't lost later on due to it having a variable name that wasn't expected as the REST interface expects 'id'.
Testing
Testing Performed
All steps to reproduce in both FISH-1167 and ZDEP-1987 have been tested and work correctly. All unit tests within the modules passed.
Testing Environment
Zulu JDK 1.8_212 on Ubuntu 20.04.2 with Maven 3.6.3