FISH-1415: Write updated log information all at once to logging.properties file. #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
lprimak
approved these changes
May 24, 2021
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-1415: Write updated log information all at once to logging.properties file.
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit cd24d29 Signed-off-by: JamesHillyard <[email protected]>
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit cd24d29 Signed-off-by: JamesHillyard <[email protected]>
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit cd24d29 Signed-off-by: JamesHillyard <[email protected]>
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
FISH-1415: Write updated log information all at once to logging.properties file.
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 23, 2021
FISH-1415: Write updated log information all at once to logging.properties file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the Web console to update the logging properties of the server, they are sent one by one to the REST endpoints. This means that the file is updated multiple times and that the file contents is checked multiple times for changes.
Testing
Testing Performed
verified all changed data onsc reen is written to the file.
Testing Environment
Zulu 8.52.0.23-CA-macosx (build 1.8.0_282-b08) on Mac 11.2.3 with Maven 3.6.3
Documentation
None, fix issue within codebase