FISH-1158 OpenAPI document creation failed when using @Schema annotation with Enum missing a nullcheck #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 29, 2020 08:44
sync master
FISH-326 Add Profile to Deploy Internal JARs
FISH-326 Refactor Deployment Profiles
lprimak
approved these changes
Mar 2, 2021
|
jenkins test please |
AlanRoth
changed the title
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
May 4, 2021
FISH-1158 OpenAPI document creation failed when using @Schema annotation with Enum missing a nullcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Further development on FISH-885, missing a null check caused NPE when @Schema was used on a static reference in an Enum.
Testing
Testing Performed
Build tests and manual testing with this reproducer
Testing Environment
Linux Manjaro
Zulu JDK 8_275
Notes for Reviewers
Refer to FISH-885 for what the original issue was trying to fix.