FISH-1069 Rationalise Fault Tolerance Configuration #5131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fault Tolerance configuration was a bit of a mess, with the correct configuration parameters not being used, and the incorrect ones being reported. This commit makes the managed executor names the configurable options, and removes the dead configuration options. As an added bonus, the set command now validates the executor names. This should work as expected in the admin console and from the command line. Signed-off-by: Matthew Gill <[email protected]>
|
jenkins test please |
MeroRai
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Great work @MattGill98. The validation to the set command is an excellent addition.
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
FISH-1069 Rationalise Fault Tolerance Configuration
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
FISH-1069 Rationalise Fault Tolerance Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fault Tolerance configuration was a bit of a mess, with the correct
configuration parameters not being used, and the incorrect ones being
reported.
This commit makes the managed executor names the configurable options,
and removes the dead configuration options.
As an added bonus, the set command now validates the executor names.
This should work as expected in the admin console and from the command
line.
Docs: payara/Payara-Community-Documentation#135