feature(config-api): Make MPCONFIG in TranslatedConfigView debugable / FISH-1079 #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When no value can be found and no default has been given, a warning should be printed, so we have a useful error message. Important e. g. to track causes when DB connections fail, etc. 2. When a value has been found, it might be the wrong one due to wrong ordinal config, human mistake, etc etc. Enabling debugging with the TranslatedConfigView will reveal the origin of a value. Closes payara#5126
AlanRoth
added
PR: CLA
AlanRoth
changed the title
|
jenkins test please |
AlanRoth
reviewed
Feb 19, 2021
nucleus/admin/config-api/src/main/java/org/glassfish/config/support/TranslatedConfigView.java
Outdated
Show resolved
Hide resolved
nucleus/admin/config-api/src/main/java/org/glassfish/config/support/TranslatedConfigView.java
Outdated
Show resolved
Hide resolved
nucleus/admin/config-api/src/main/java/org/glassfish/config/support/TranslatedConfigView.java
Outdated
Show resolved
Hide resolved
Rename variable Co-authored-by: Alan <[email protected]>
Pandrex247
reviewed
Feb 23, 2021
nucleus/admin/config-api/src/main/java/org/glassfish/config/support/TranslatedConfigView.java
Outdated
Show resolved
Hide resolved
| m3.reset(stringValue); | ||
| Logger.getAnonymousLogger().fine("Found property '"+matchValue+"' in source '"+cValue.getSourceName()+"' with ordinal '"+cValue.getSourceOrdinal()+"'"); |
There was a problem hiding this comment.
Suggested change
| Logger.getAnonymousLogger().fine("Found property '"+matchValue+"' in source '"+cValue.getSourceName()+"' with ordinal '"+cValue.getSourceOrdinal()+"'"); | |
| Logger.getAnonymousLogger().fine("Found property '" + matchValue + "' in source '" + cValue.getSourceName() + "' with ordinal '" + cValue.getSourceOrdinal() + "'"); |
nucleus/admin/config-api/src/main/java/org/glassfish/config/support/TranslatedConfigView.java
Outdated
Show resolved
Hide resolved
Pandrex247
reviewed
Feb 23, 2021
nucleus/admin/config-api/src/main/java/org/glassfish/config/support/TranslatedConfigView.java
Outdated
Show resolved
Hide resolved
…pport/TranslatedConfigView.java Spacing
Pandrex247
approved these changes
Feb 23, 2021
AlanRoth
approved these changes
Feb 23, 2021
|
jenkins test please |
|
Oh! That went smooth... So I guess the idea was a good fit. Thanks for fixing the style issues. @AlanRoth I'll add some docs for this in the docs repo. |
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
feature(config-api): Make MPCONFIG in TranslatedConfigView debugable / FISH-1079
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
…5126-mpconfig-msg feature(config-api): Make MPCONFIG in TranslatedConfigView debugable / FISH-1079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5126
Microprofile Config based variable substitution in TranslatedConfigView:
should be printed, so we have a useful error message. Important e. g.
to track causes when DB connections fail, etc.
ordinal config, human mistake, etc etc. Enabling debugging
with the TranslatedConfigView will reveal the origin of a value.
(Thx, MicroProfile Config API 2.0!!!)
Important Info
This is a demo to outline how this could be done. Might need polishing.
Testing
New tests
None yet.
Testing Performed
None yet, except for the test cases already present.
Testing Environment
AdoptJDK 11.0.9, Maven 3.6, Linux (Fedora 33)
Documentation
None yet.
Notes for Reviewers
None so far.