FISH-1061 Fix NullPointer when Configuring a Notifier against a non-DAS Instance or Config #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You would get an NPE when configuring notifiers for anything other than the server-config, due to the default config tags not being present in the default domain.xml. This change makes it so default config tags will be created if not already present Signed-off-by: Andrew Pielage <[email protected]>
Pandrex247
commented
Feb 5, 2021
| actionReport.setActionExitCode(ActionReport.ExitCode.SUCCESS); | ||
| return cProxy; | ||
| } | ||
| ConfigSupport.apply(cProxy -> { |
There was a problem hiding this comment.
No change in config here, just using a lambda
Pandrex247
changed the title
Cousjava
approved these changes
Feb 8, 2021
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You would get an NPE when configuring notifiers for anything other than the server-config, due to the default config tags not being present in the default domain.xml. This change makes it so default config tags will be created if not already present.
Important Info
Blockers
None
Testing
New tests
Nope
Testing Performed
Start a fresh domain:
User should receive no errors and see that config changes taking effect in the domain config
Testing Environment
Windows 10, JDK 8u282
Documentation
Nada