Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FISH-1019] GlassFishProperties fix by @bhanuunrivalled #5101

Merged
merged 4 commits into from
Jan 24, 2021

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Jan 24, 2021

Thank you @bhanuunrivalled for your fix
Incorporates PR #4917

Fixes #4657

@lprimak
Copy link
Contributor Author

lprimak commented Jan 24, 2021

jenkins test

@lprimak
Copy link
Contributor Author

lprimak commented Jan 24, 2021

@bhanuunrivalled I could not push my changes on top of your PR so I created my own

Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but LGTM - "what could go wrong?"

@lprimak
Copy link
Contributor Author

lprimak commented Jan 24, 2021

jenkins test

@lprimak lprimak self-assigned this Jan 24, 2021
@lprimak lprimak added PR: CLA CLA submitted on PR by the contributor Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect Type: Community Contribution labels Jan 24, 2021
@lprimak
Copy link
Contributor Author

lprimak commented Jan 24, 2021

jenkins test

@lprimak lprimak merged commit faf5769 into payara:master Jan 24, 2021
@lprimak lprimak deleted the bhan-fix-2 branch January 24, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: CLA CLA submitted on PR by the contributor Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlassFishProperties throws NPE if the Properties is null.
4 participants