FISH-877 Add config ordinal to cloud config sources #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
MattGill98
approved these changes
Jan 28, 2021
MeroRai
approved these changes
Jan 28, 2021
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
May 4, 2021
Merge pull request payara#5092 from Cousjava/FISH-877-mp-config-ordinals-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix
Important Info
Blockers
Testing
New tests
New test add at https://github.com/payara/Payara/compare/master...Cousjava:FISH-877-mp-config-ordinals-cloud?expand=1#diff-04fc586ba2c85eee6bd5376c25be567f24a810aba8d3b61b686ddb8064cfe54fR122
Testing Performed
Using the reproducer from FISH-892, also added a config property with the same key but a different value to the domain config properties. Used curl on the endpoint to get the cloud value. Changed the ordinal of cloud config source to be less then that of domain and ran curl again, this time got the value from the domain config.
Testing Environment
Zulu JDK 1.8_272 on Ubuntu 20.10 with Maven 3.6.3