[FISH-759] sort instances in admin console #5074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lprimak
added
PR: CLA
|
Please remove |
lprimak
suggested changes
Dec 29, 2020
lprimak
reviewed
Dec 29, 2020
...us/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ListInstancesCommand.java
Outdated
Show resolved
Hide resolved
lprimak
reviewed
Dec 29, 2020
...us/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ListInstancesCommand.java
Outdated
Show resolved
Hide resolved
sgflt
force-pushed
the
4795-sort-instances
branch
from
ab69439 to
4e668b7
Compare
lprimak
approved these changes
Dec 30, 2020
...us/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ListInstancesCommand.java
Outdated
Show resolved
Hide resolved
...us/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ListInstancesCommand.java
Outdated
Show resolved
Hide resolved
...us/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ListInstancesCommand.java
Outdated
Show resolved
Hide resolved
...us/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ListInstancesCommand.java
Outdated
Show resolved
Hide resolved
|
jenkins test |
|
I did like the diamond operator changes, can you leave them in this PR (just remove the final stuff) |
|
Already moved all code style changes into separate PR. This now contains just sorting one liners. :) |
|
If you could add back the diamond interface fixes but not the finals in this PR I appreciate it |
|
Okay, but it is hard to keep other things like |
Please feel free to refactor but don't try to introduce new code style that doesn't already exist (such as finals everywhere) |
lprimak
approved these changes
Dec 30, 2020
|
jenkins test |
AlanRoth
added
Type: Community Contribution
and removed
Status: Accepted
dmatej
approved these changes
Jan 15, 2021
...us/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ListInstancesCommand.java
Show resolved
Hide resolved
lprimak
changed the title
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
* FISH-759 Sort instance list by name * FISH-759 Sort also configurations * FISH-759 Got rid of wildcard import * FISH-759 Updated JDK 1.4 generics to JDK 8 style in ClusterHandler * FISH-759 Updated JDK 1.5 generics to JDK 8 style in ListInstancesCommand * FISH-759 Updated JDK 1.4 generics to JDK 8 style in ListInstancesCommand * FISH-759 Removed unused import * FISH-759 Removed unused variable * FISH-759 Fixed spacing around = * FISH-759 IntelliJ automatic code clean up * FISH-759 Fixed whitespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4795
Description
Important Info
Blockers
Testing
New tests
Testing Performed
Testing Environment
Documentation
Notes for Reviewers