Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-873 TransactionScopedCDIUtil Context Util - can now be run without a context #5031

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Dec 4, 2020

Description

Now checking for no-invocation context run during testing
Not sure if this affects real-world applications, but I think it may
Fixes test issue with #5010

Important Info

Blockers

None

Testing

Was caused by the following throwing WARNINGS, but not errors, thus not failing the build

testcase name="testafterBeanDiscovery" classname="org.glassfish.cdi.transaction.TransactionScopedContextExtensionTest" time="0.538">
<error message="No Current Invocation present" type="java.lang.IllegalStateException">java.lang.IllegalStateException: No Current Invocation present at org.glassfish.cdi.transaction.TransactionScopedContextExtensionTest.testafterBeanDiscovery(TransactionScopedContextExtensionTest.java:76) </error>
<system-err>

Testing Performed

tests now pass without warning

Testing Environment

jdk 8, mac

Documentation

None

Notes for Reviewers

Relates to FISH-790

@lprimak
Copy link
Contributor Author

lprimak commented Dec 4, 2020

jenkins test

@lprimak lprimak changed the title FISH-873 TransactionScopedCDIUtil Context Util - can be run without a context FISH-873 TransactionScopedCDIUtil Context Util - can now be run without a context Dec 4, 2020
@lprimak
Copy link
Contributor Author

lprimak commented Dec 5, 2020

jenkins test

@dmatej dmatej merged commit 7dcf5d1 into payara:master Dec 7, 2020
@lprimak lprimak deleted the CDI-TxScoped-Ctx-Fix branch December 24, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants