FISH-275 Don't create EMF on DAS if no schema generation needed #5015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e replacement on remote N.B. This currently fails on authentication on the remote instance
|
Jenkins test please |
Cousjava
changed the title
MattGill98
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix.
Important Info
Testing
New tests
Testing Performed
Create an instance, then add a system property the the key of APP_DS_NAME pointing and the key of the name of a custom data source. Deploy the application on the Jira with the target of just the instance.
Test suites executed
Testing Environment
Zulu JDK 1.8_272 on Ubuntu 18.04 with Maven 3.6.3
Documentation
Notes for Reviewers
Community version of payara/payara-enterprise#234