FISH-765 #4653 Propagate VirtualServer config to WebModule #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgflt
changed the title
sgflt
force-pushed
the
4653-fixed-virtual-server-config-propagation
branch
from
eed5c16 to
a833c9d
Compare
AlanRoth
added
PR: CLA
AlanRoth
changed the title
- left for backward compatibility
sgflt
force-pushed
the
4653-fixed-virtual-server-config-propagation
branch
from
6c16d43 to
9b5fc75
Compare
|
jenkins test please |
|
jenkins test |
|
@sgflt if this fails, can you please re-merge master and re-push this PR? |
MarkWareham
requested review from
Cousjava,
lprimak,
MattGill98 and
Pandrex247
lprimak
approved these changes
Dec 24, 2020
|
Took me a bit to see what's going on, but looks like a nice refactoring and fixes the problem |
|
Thank you for the contribution! |
lprimak
pushed a commit
that referenced
this pull request
Feb 5, 2021
…propagation FISH-765 #4653 Propagate VirtualServer config to WebModule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This a bug fix to fix the issue described in #4653
Testing Performed
Manual verification of result and "mvn clean verify -pl :web-glue"