Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-375 Remove Production Domain From Build #4990

Merged
merged 1 commit into from
Nov 13, 2020
Merged

FISH-375 Remove Production Domain From Build #4990

merged 1 commit into from
Nov 13, 2020

Conversation

MattGill98
Copy link
Contributor

Description

This is an improvement. The domain still exists in production-template.jar, but no longer features in any build stages.

Testing

Testing Performed

Starting the server-full docker image and payara final artifact.

The domain still exists in production-template.jar, but no longer
features in any build stages.

Signed-off-by: Matthew Gill <[email protected]>
@MattGill98 MattGill98 self-assigned this Nov 11, 2020
@MattGill98
Copy link
Contributor Author

jenkins test please

1 similar comment
@MattGill98
Copy link
Contributor Author

jenkins test please

Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from conversation about possibly removing the template jar as well, looks good. Build is quicker at least 😊

@MattGill98
Copy link
Contributor Author

jenkins test please

@MattGill98 MattGill98 merged commit 895bab1 into payara:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants